Skip to content

fix(typescript-urql-graphcache): improve typing#1110

Merged
eddeee888 merged 1 commit intodotansimha:mainfrom
dargmuesli:patch-1
Mar 11, 2026
Merged

fix(typescript-urql-graphcache): improve typing#1110
eddeee888 merged 1 commit intodotansimha:mainfrom
dargmuesli:patch-1

Conversation

@dargmuesli
Copy link
Copy Markdown
Contributor

@dargmuesli dargmuesli commented May 23, 2025

Description

Linting typescript-urql-graphcache's output file showed some room for improvement, so this PR resolves a duplicate import source and improves typing for "empty object".

Related # (issue)

#1109
#445

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

n/a

How Has This Been Tested?

  • existing test snapshots have been updated

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

n/a

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 23, 2025

🦋 Changeset detected

Latest commit: 829c67a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-codegen/typescript-urql-graphcache Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dargmuesli dargmuesli changed the title fix(types): simplify fix(typescript-urql-graphcache): improve typing May 23, 2025
@dargmuesli
Copy link
Copy Markdown
Contributor Author

let me kindly cc last editors of the changed line @beerose and @JoviDeCroock for review if time allows

@eddeee888
Copy link
Copy Markdown
Collaborator

hi @dargmuesli , apologies! I didn't see these updates.
Could you please rebase with the latest main and let me know which PRs are waiting for reviews? 🙏

@dargmuesli
Copy link
Copy Markdown
Contributor Author

dargmuesli commented Mar 11, 2026

done @eddeee888 thanks for getting back to this ❤️
no other PR I'd highlight especially at the moment, I'll tag you if I come across one

- resolve a duplicate import
- improve typing for "empty object"
- respect `defaultScalarType`
@eddeee888 eddeee888 merged commit e60bf64 into dotansimha:main Mar 11, 2026
15 checks passed
@dargmuesli dargmuesli deleted the patch-1 branch March 12, 2026 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants